adds a build step to make sure docker-compose is there #288
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm surprised to see that docker-compose still wasn't detected, but seeing as we wanna move away from Docker-based action, maybe best to put this PR on ice for now? 🧊 |
1 task
|
Superseded by #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR adds a step in the github/workflows/build.yml file to check for installation of docker-compose.
Other PRs have failing Docker tests because it can't find
docker-composeso I'm hoping this will remedy that until we move away from Docker.The part I'm not super sure about is if the
testsstep must "need" thepreparestep.At any rate, it looks like it still can't find it, even though the
preparejob runs correctly. :(